-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for sass and sass-embedded 1.68 compatibility #13
Comments
Discourse has a custom stylesheet pipeline which compiles things 'just in time'. The only place we were still running sass files through sprockets was for the `/tests` route in development mode. This use can be removed by compiling the relevant stylesheets through ember-cli instead (which we were already doing for testem runs) This work was prompted by the incompatibility of dartsass-sprockets with the latest sass-embedded release (tablecheck/dartsass-sprockets#13)
I tried working on a PR for dartsass-ruby today to fix this issue, but without success yet. Mostly because I've never looked at any of this code before. I tried making similar changes to the sassc-embedded-shim-ruby commit mentioned, but something is still not working correctly since the tests don't pass. In the meantime, I've made a PR to dartsass-ruby to simply restrict the Note that the breakage happens with 1.67.0 . The upstream dart-sass project mentions a 'potentially breaking bugfix' in the 1.67.0 changelog, which I think could be related to the root cause. Perhaps that will help someone understand what changes need to be made to dartsass-ruby. If anyone else wants to try making a PR for dartsass-ruby that implements a proper fix, then that would be great! |
Author of
The fixes needed are already made in Finally, I have to say to the owner of this project: You forked it, you maintain it. Please be responsible. |
@ntkme Thanks for the background information. It's not clear to me what you recommendation is for the best way forward. Without wanting to go too far off-topic for this issue, do you agree that the proposed changes outlined in #2 are a good idea? Or is there some other approach that you would recommend instead? As far as I'm aware, there's no other gem offering integration between dartsass and sprockets, i.e. as an alternative to this one. |
Yes. #2 is the right way forward if people still would like to continue use sprockets... |
This PR has been merged, and released in dartsass-ruby 3.0.2, so hopefully various projects will start working again.
Just for clarity, this bit is still required 😄 |
Closing as the issue is fixed in dartsass-ruby. |
Looks like there is some kind of breaking change in sass 1.68
Looks like https://github.com/tablecheck/dartsass-ruby/blob/51039a20e5a05aa778baed3fc4edfcb2f6efd3cf/lib/sassc/import_handler.rb#L109 needs an update, I guess something similar to sass-contrib/sassc-embedded-shim-ruby@cb35862
(Sorry would raise the issue at
dartsass-ruby
but issues seem to be disabled on that repository.)The text was updated successfully, but these errors were encountered: