feat(tablekit-modal-dialog): add maxWidth and maxHeight props #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 1 files 28 suites 30s ⏱️ Results for commit dd335fe. ♻️ This comment has been updated with latest results. |
gazpachu
previously approved these changes
Aug 18, 2021
SimeonC
requested changes
Aug 18, 2021
|
@irmir what's the status of this PR? I thought this would be ready to merge today |
irmir
force-pushed
the
add-maxWidth-maxHeight-modal-dialog
branch
2 times, most recently
from
fb6fdb0
to
cac5d94
Compare
SimeonC
reviewed
Aug 20, 2021
irmir
force-pushed
the
add-maxWidth-maxHeight-modal-dialog
branch
2 times, most recently
from
f4d2bfc
to
5f2ee4c
Compare
irmir
force-pushed
the
add-maxWidth-maxHeight-modal-dialog
branch
from
5f2ee4c
to
5eea3be
Compare
SimeonC
approved these changes
Aug 20, 2021
irmir
added
internal
gazpachu
approved these changes
Aug 23, 2021
|
🚀 PR was released in |
tablecheck-public-automation
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completes #31
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @tablecheck/tablekit-input-button@1.0.2-canary.33.b6e8bc0d7e1ee8f160d12db9443d05a9ca0e88cf.0 npm install @tablecheck/tablekit-modal-dialog@1.0.1-canary.33.b6e8bc0d7e1ee8f160d12db9443d05a9ca0e88cf.0 # or yarn add @tablecheck/tablekit-input-button@1.0.2-canary.33.b6e8bc0d7e1ee8f160d12db9443d05a9ca0e88cf.0 yarn add @tablecheck/tablekit-modal-dialog@1.0.1-canary.33.b6e8bc0d7e1ee8f160d12db9443d05a9ca0e88cf.0