Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): improve icon config error #48

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Conversation

SimeonC
Copy link
Collaborator

@SimeonC SimeonC commented Aug 30, 2021

Add additional details to the error to assist fixing icon configuration

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/tablekit-alert@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-avatar@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-badge@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-banner@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-button-group@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-button@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-calendar@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-checkbox@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-free-icon-config@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-icon@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-inline-dialog@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-input-button@1.0.2-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-input@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-item@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-language-selector@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-logo@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-modal-dialog@1.0.2-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-panel@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-password-field@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-phone-input@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-pro-icon-config@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-radio@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-select@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-sidenav@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-table@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-tabs@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-tag@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-textarea@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-toggle@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-tooltip@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
npm install @tablecheck/tablekit-topnav@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
# or 
yarn add @tablecheck/tablekit-alert@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-avatar@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-badge@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-banner@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-button-group@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-button@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-calendar@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-checkbox@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-free-icon-config@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-icon@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-inline-dialog@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-input-button@1.0.2-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-input@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-item@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-language-selector@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-logo@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-modal-dialog@1.0.2-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-panel@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-password-field@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-phone-input@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-pro-icon-config@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-radio@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-select@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-sidenav@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-table@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-tabs@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-tag@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-textarea@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-toggle@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-tooltip@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0
yarn add @tablecheck/tablekit-topnav@1.0.1-canary.48.02a96c9925fd5e9f93799caaa98b27b2437d0cc6.0

@SimeonC SimeonC added the patch Increment the patch version when merged label Aug 30, 2021
Add additional details to the error to assist fixing icon configuration

Signed-off-by: SimeonC <simeon@thehavens.co.nz>
@github-actions
Copy link

Unit Test Results

    1 files    28 suites   31s ⏱️
191 tests 191 ✔️ 0 💤 0 ❌

Results for commit 330ad3e.

@SimeonC SimeonC merged commit 58f1568 into main Aug 30, 2021
@SimeonC SimeonC deleted the improve-icon-config-error branch August 30, 2021 07:45
@tablecheck-public-automation tablecheck-public-automation added the released This issue/pull request has been released. label Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants