Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storybook icon config #6

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Conversation

wahidfarid
Copy link
Collaborator

  • remove '@tablecheck/tablekit-free-icon-config' import from
    preview.tsx

  • add '@tablecheck/tablekit-free-icon-config' imports to all
    stories that include icons

Fixes #5

@wahidfarid
Copy link
Collaborator Author

I'm sure there's a more general solution than importing the config for every story file, however i haven't yet found it and decided to at least do this as a stop-gap measure

@wahidfarid wahidfarid requested a review from SimeonC August 4, 2021 09:34
@wahidfarid wahidfarid added bug Something isn't working skip-release Preserve the current version when merged labels Aug 4, 2021
@SimeonC
Copy link
Collaborator

SimeonC commented Aug 4, 2021

Ah, sorry. Forgot to document what the "Labels" need to be in the CONTRIBUTING.md file. Can you add a description from here:

one_of: major,minor,patch,internal
none_of: invalid,wontfix,duplicate,question

@wahidfarid wahidfarid added the patch Increment the patch version when merged label Aug 4, 2021
Copy link
Collaborator

@SimeonC SimeonC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, should have read properly. The commit message for this should be docs: ... not fix: ... as it doesn't affect the components themselves. The label can be "Internal"

@github-actions
Copy link

github-actions bot commented Aug 4, 2021

Unit Test Results

    1 files    30 suites   32s ⏱️
196 tests 194 ✔️ 2 💤 0 ❌

Results for commit b3a9758.

♻️ This comment has been updated with latest results.

@wahidfarid wahidfarid added documentation Changes only affect the documentation and removed bug Something isn't working labels Aug 4, 2021
- remove '@tablecheck/tablekit-free-icon-config' import from
`preview.tsx`

- add '@tablecheck/tablekit-free-icon-config' imports to all
stories that include icons

Completes #5
@wahidfarid wahidfarid added internal Changes only affect the internal API and removed documentation Changes only affect the documentation patch Increment the patch version when merged labels Aug 4, 2021
@wahidfarid
Copy link
Collaborator Author

Passed the label checker. are these the correct labels?

@wahidfarid wahidfarid requested a review from SimeonC August 4, 2021 09:54
@wahidfarid wahidfarid merged commit 01b5a99 into main Aug 5, 2021
@wahidfarid wahidfarid deleted the 5-fix-storybook-icon-config branch August 5, 2021 10:24
@github-actions github-actions bot added the released This issue/pull request has been released. label Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook examples with icons are broken
3 participants