-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: storybook icon config #6
Conversation
I'm sure there's a more general solution than importing the config for every story file, however i haven't yet found it and decided to at least do this as a stop-gap measure |
Ah, sorry. Forgot to document what the "Labels" need to be in the tablekit/.github/workflows/label_checker.yml Lines 19 to 20 in debd282
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, should have read properly. The commit message for this should be docs: ...
not fix: ...
as it doesn't affect the components themselves. The label can be "Internal"
Unit Test Results 1 files 30 suites 32s ⏱️ Results for commit b3a9758. ♻️ This comment has been updated with latest results. |
79d8371
to
6ea560c
Compare
- remove '@tablecheck/tablekit-free-icon-config' import from `preview.tsx` - add '@tablecheck/tablekit-free-icon-config' imports to all stories that include icons Completes #5
6ea560c
to
b3a9758
Compare
Passed the label checker. are these the correct labels? |
remove '@tablecheck/tablekit-free-icon-config' import from
preview.tsx
add '@tablecheck/tablekit-free-icon-config' imports to all
stories that include icons
Fixes #5