fix(tablekit-modal-dialog): correctly forward on data-testid prop #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward on the data-testid prop so we can target a dialog correctly when there are multiple displayed.
SimeonC
force-pushed
the
fix-modal-dialog-testid-forwarding
branch
from
778eba1
to
0ad9d66
Compare
staevs
approved these changes
Mar 30, 2022
SashaShostyr
approved these changes
Mar 30, 2022
|
🚀 PR was released in |
tablecheck-public-automation
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward on the data-testid prop so we can target a dialog correctly when there are multiple displayed.
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @tablecheck/tablekit-modal-dialog@3.1.2-canary.91.2062204281.0 # or yarn add @tablecheck/tablekit-modal-dialog@3.1.2-canary.91.2062204281.0