Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix decoding with k == m == 256 #97

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Fix decoding with k == m == 256 #97

merged 4 commits into from
Sep 20, 2023

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Sep 20, 2023

Fixes #96

@exarkun
rewrite test_small with Hypothesis
6bc68a3 
Hypothesis reproduces the problem more quickly than the prior pseudorandom
test.
@exarkun exarkun marked this pull request as ready for review September 20, 2023 15:17
hacklschorsch
hacklschorsch approved these changes Sep 20, 2023
View reviewed changes
Copy link

@hacklschorsch hacklschorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off-by-ones, gnaa. Nice find!

@exarkun exarkun merged commit 049599a into tahoe-lafs:master Sep 20, 2023
51 of 52 checks passed
@exarkun exarkun deleted the 96.decoder-crash branch September 20, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacklschorsch hacklschorsch hacklschorsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zfec.Decoder.decode segfaults for k == m == 256
2 participants
@exarkun @hacklschorsch