-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] Renamed allocate_memory_ndarray to allocate_memory_on_device #8240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Jun 28, 2023
listerily
added a commit
that referenced
this pull request
Jun 28, 2023
ghstack-source-id: 504969b4055ca21903ef16e459a27253fffd7517 Pull Request resolved: #8240
for more information, see https://pre-commit.ci
…ory_on_device" [ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
Jun 28, 2023
ghstack-source-id: 9ccd6647d91a6ce5257605b7d7b73d03aa8b3923 Pull Request resolved: #8240
…ory_on_device" [ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
Jun 28, 2023
ghstack-source-id: b2987cbed70aa0eaa553ccd25621d90fcf59b7b5 Pull Request resolved: #8240
This was referenced Jun 28, 2023
Merged
This was referenced Jul 6, 2023
…ory_on_device" [ghstack-poisoned]
for more information, see https://pre-commit.ci
…ory_on_device" [ghstack-poisoned]
lin-hitonami
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ory_on_device" [ghstack-poisoned]
taichi-gardener
pushed a commit
that referenced
this pull request
Jul 11, 2023
ghstack-source-id: 2f15af8aaacb16bfd082bee33c593d4a45be9788 Pull Request resolved: #8240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):