Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rhi] MetalSurface functions #8274

Merged
merged 23 commits into from
Jul 13, 2023

Conversation

AntonioFerreras
Copy link
Contributor

@AntonioFerreras AntonioFerreras commented Jul 10, 2023

Issue: #

Brief Summary

🤖 Generated by Copilot at a89e235

This pull request adds the ability to create and use a Metal surface for rendering graphics using the RHI interface. It introduces the MetalSurface class in metal_device.h and metal_device.mm, and links the QuartzCore framework in CMakeLists.txt.

Walkthrough

🤖 Generated by Copilot at a89e235

  • Add the MetalSurface class and the create_surface method to support rendering on Metal (link, link, link, link)
  • Add the QuartzCore framework and header to use the CAMetalLayer and CAMetalDrawable classes for the MetalSurface (link, link, link)
  • Add helper functions to convert RHI enums to Metal enums for buffer format, image dimension, and image usage (link)
  • Add a TODO comment to the MetalShaderResourceSet class to indicate the need for raster resources support (link)

@netlify
Copy link

netlify bot commented Jul 10, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 905857d
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/64b04af00fc0d40008d1be66
😎 Deploy Preview https://deploy-preview-8274--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@bobcao3 bobcao3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobcao3 bobcao3 merged commit 6994dbd into taichi-dev:master Jul 13, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants