This repository has been archived by the owner on May 3, 2024. It is now read-only.

Skip invalid txs due to nonce, intrinsic gas and insufficient funds #115

Merged

xiaodino merged 44 commits into main from xiaodino/invalid-tx-nonce-eth-balance

Aug 14, 2023

xiaodino commented Jun 20, 2023 •

edited

Loading

Description

Support skipping the following invalid transactions:

nonce too low
nonce too high
intrinsic gas too low
insufficient funds for gas * price + value

Issue Link

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Contents

Check if a TX is invalid by adding a few auxiliary columns to the TX table.
The related PR in zkevm-specs is Specs for invalid transaction filter. privacy-scaling-explorations/zkevm-specs#338

xiaodino added 30 commits

June 1, 2023 00:44


          Add invalid signature support

1f0abe8


          Update Ref. spec 0. in tx_circuit.rs

8a890e1


          Update

9d894b8


          Support invalid tx in begin_tx and end_tx

d4472d1


          Update

ccca3d5


          Revert changes in begin_tx.rs

994d959


          Add nonce back

cb146a8


          Update

d37638e


          Update

de2607e


          Update

0f76a4d


          Add comments

352e9be


          Rename mul_gas_fee_by_gas to gas_fee

7179baa


          Debug

ab275b0


          Revert "Rename mul_gas_fee_by_gas to gas_fee"

a09bc8a

This reverts commit 7179baa.


          Update

d3c4997


          Update

9229afc


          Clean code

3916fe1


          Upgrade snark-verifier

35d6b25


          Fix failed tests

fd78941


          Update

8b67a9e


          Clean test

f585885


          Update

7c5854a


          Update

d59c7b3


          Remove default method in eth-types/src/lib.rs

87dbc6b


          Remove type

322cbc2


          Revert formatting in GoLang in trace.go

334b25c


          Update

a81aeb7


          Addressed comments

b8ff9cf


          Revert changes in evm_circuit/param.rs

2275ce4


          Update

df38b6d


          Support invalid tx

b203a7d

xiaodino marked this pull request as draft

June 20, 2023 17:04

github-actions bot added crate-bus-mapping crate-eth-types crate-external-tracer crate-geth-utils crate-mock crate-zkevm-circuits labels


          Update

55a3789

xiaodino changed the title ~~Xiaodino/invalid tx nonce eth balance~~ Skip invalid txs due to nonce and Eth balance

xiaodino changed the title ~~Skip invalid txs due to nonce and Eth balance~~ Skip invalid txs due to nonce and insufficient funds

xiaodino changed the title ~~Skip invalid txs due to nonce and insufficient funds~~ Skip invalid txs due to nonce, intrinsic gas and insufficient funds

xiaodino marked this pull request as ready for review

June 21, 2023 06:18

xiaodino and others added 2 commits

June 23, 2023 15:09


          Update

1be8147


          Merge branch 'main' into xiaodino/invalid-tx-nonce-eth-balance

6b2790b

Brechtpd reviewed

View reviewed changes

bus-mapping/src/circuit_input_builder/input_state_ref.rs Outdated Show resolved Hide resolved

xiaodino and others added 3 commits

June 26, 2023 00:56


          Merge branch 'main' into xiaodino/invalid-tx-nonce-eth-balance

656cdf5


          Work around zero gas payment to non-existing coinbase address

4b1781b


          Always read the caller balance in begin_tx

196010c

xiaodino mentioned this pull request

Skip invalid tx #32

Open

Brechtpd approved these changes

View reviewed changes


          Merge branch 'xiaodino/invalid-tx-nonce-eth-balance' of github.com:ta…

15bc737

…ikoxyz/zkevm-circuits into xiaodino/invalid-tx-nonce-eth-balance

Brechtpd mentioned this pull request

feat: BeginTx and EndTx support taiko's 1559 smtmfft/zkevm-circuits#18

Closed

5 tasks


          Resolve merge conflicts

189e66d

johntaiko approved these changes

View reviewed changes

xiaodino merged commit 7aef0f5 into main

17 of 20 checks passed

johntaiko mentioned this pull request

Support eip-1559 and Evm-circuit in aggregation #136

Merged

15 tasks

CeciliaZ030 added a commit that referenced this pull request


          Revert "Skip invalid txs due to nonce, intrinsic gas and insufficient…

cf55818

… funds (#115)"

This reverts commit 7aef0f5.

smtmfft added a commit that referenced this pull request


          Revert "Skip invalid txs due to nonce, intrinsic gas and insufficient…

ca0c5b8

… funds (#115)"

This reverts commit 7aef0f5.

CeciliaZ030 mentioned this pull request

New invalid tx #157

Open

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

crate-bus-mapping crate-eth-types crate-external-tracer crate-geth-utils crate-mock crate-zkevm-circuits