This repository has been archived by the owner on May 3, 2024. It is now read-only.
In-circuit blockhash calculation #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggkitsas
force-pushed
the
blockhash-final
branch
from
befddc0
to
1a4b55e
Compare
ggkitsas
force-pushed
the
blockhash-final
branch
from
406412f
to
7007092
Compare
ggkitsas
changed the title
Brechtpd
reviewed
Sep 3, 2023
Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
ggkitsas
force-pushed
the
blockhash-final
branch
from
d66d0bc
to
2f83e30
Compare
smtmfft
reviewed
Sep 6, 2023
smtmfft
reviewed
Sep 7, 2023
smtmfft
reviewed
Sep 7, 2023
smtmfft
reviewed
Sep 7, 2023
Brechtpd
reviewed
Sep 7, 2023
einar-taiko
reviewed
Oct 17, 2023
Comment on lines
+219
to
+225
| let output_hi = output.iter().take(16).fold(F::ZERO, |acc, byte| { | ||
| acc * F::from(BYTE_POW_BASE) + F::from(*byte as u64) | ||
| }); | ||
|
|
||
| let output_lo = output.iter().skip(16).fold(F::ZERO, |acc, byte| { | ||
| acc * F::from(BYTE_POW_BASE) + F::from(*byte as u64) | ||
| }); |
There was a problem hiding this comment.
einar-taiko
reviewed
Oct 17, 2023
Comment on lines
+1258
to
+1263
| let hash_hi = hash.iter().take(16).fold(F::ZERO, |acc, byte| { | ||
| acc * F::from(BYTE_POW_BASE) + F::from(*byte as u64) | ||
| }); | ||
| let hash_lo = hash.iter().skip(16).fold(F::ZERO, |acc, byte| { | ||
| acc * F::from(BYTE_POW_BASE) + F::from(*byte as u64) | ||
| }); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In-circuit blockhash calculation. Design documentation can be found here: https://www.notion.so/taikoxyz/In-circuit-blockhash-calculation-docs-069984cbc14446a9a1ea88387178e9ce
Important Notes
Re-targeting #98 to
mainIssue Link
[https://github.com//issues/79]
Type of change