Use isFocused instead of isFocusVisible for Input and Textarea components
#2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do this because we always want to show the focus ring regardless of whether you used the mouse or the keyboard.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
changed the title
data-focus for Input and Textarea componentsisFocused instead of isFocusVisible for Input and Textarea components
RobinMalfait
force-pushed
the
fix/improve-data-focus
branch
from
96c0c0e
to
c8c4451
Compare
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the exposed
data-focusfor theInputandTextareacomponents.This used to use the
isFocusVisible, but for these components we always want to show a ring when it is focused regardless of whether it was focused via the keyboard or via the mouse.