Use addComponents for class strategy
#91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tailwindlabs/tailwindcss-forms/7wL2UAi53em2BZXgaNdkWFDMgmxS |
|
Works. Please merge. |
|
Hey! Thank you for your PR! This is exactly what we needed and closes a bug #64. Thanks! |
RobinMalfait
changed the title
addComponents for class strategy
|
I have same problem with important option set to class It should set preflight with important parent class and also tailwind forms should set your class with your important parent class or tailwind important parent class |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we cannot use Tailwind's
baselayer because we are migrating our product from Bootstrap. Due to this problem I noticed that probably.form-*classes should not be in thebasebucket but in thecomponentinstead when usingstrategy: 'class'.With this change classes are added in
componentsbucket.PS: I was inspired by #66, but don't know why has been closed.
Closes: #64