Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow :global selector around @tailwind #12635

Conversation

tomprats
Copy link

Here is an updated version of #8418

The full explanation is there but essentially comes down to using CSS Modules with the default of a local scope. It helps prevent any custom css from conflicting in a large project while allowing the developer to use Tailwind for most components.

@tomprats
Copy link
Author

@adamwathan @thecrypticace Can someone take a look at this? I don't want to bug you, but just want to get it on your radar! Thanks!

@RobinMalfait RobinMalfait changed the base branch from master to archive/master-2024-02-23 March 4, 2024 21:48
@tomprats
Copy link
Author

@RobinMalfait @KrisBraun Would it help this PR's chances if I rebased off of master again?

@adamwathan
Copy link
Member

Hey thanks for this! We decided to fix this more universally by just dramatically loosening the restrictions around nesting here: #13325

So this should work as expected when we tag the next release, likely today 💪

Really appreciate the PR!

@adamwathan adamwathan closed this Mar 27, 2024
@tomprats
Copy link
Author

Awesome! I appreciate the work and you letting me know! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants