Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Support negative values for {col,row}-{start,end} utilities #13781

Merged
merged 3 commits into from
Jun 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Make it possible to use multiple `<alpha-value>` placeholders in a single color definition ([#13740](https://github.com/tailwindlabs/tailwindcss/pull/13740))
- Don't prefix classes in arbitrary values of `has-*`, `group-has-*`, and `peer-has-*` variants ([#13770](https://github.com/tailwindlabs/tailwindcss/pull/13770))
- Support negative values for `{col,row}-{start,end}` utilities ([#13781](https://github.com/tailwindlabs/tailwindcss/pull/13781))

## [3.4.3] - 2024-03-27

Expand Down
16 changes: 12 additions & 4 deletions src/corePlugins.js
Original file line number Diff line number Diff line change
Expand Up @@ -741,11 +741,19 @@ export let corePlugins = {
zIndex: createUtilityPlugin('zIndex', [['z', ['zIndex']]], { supportsNegativeValues: true }),
order: createUtilityPlugin('order', undefined, { supportsNegativeValues: true }),
gridColumn: createUtilityPlugin('gridColumn', [['col', ['gridColumn']]]),
gridColumnStart: createUtilityPlugin('gridColumnStart', [['col-start', ['gridColumnStart']]]),
gridColumnEnd: createUtilityPlugin('gridColumnEnd', [['col-end', ['gridColumnEnd']]]),
gridColumnStart: createUtilityPlugin('gridColumnStart', [['col-start', ['gridColumnStart']]], {
supportsNegativeValues: true,
}),
gridColumnEnd: createUtilityPlugin('gridColumnEnd', [['col-end', ['gridColumnEnd']]], {
supportsNegativeValues: true,
}),
gridRow: createUtilityPlugin('gridRow', [['row', ['gridRow']]]),
gridRowStart: createUtilityPlugin('gridRowStart', [['row-start', ['gridRowStart']]]),
gridRowEnd: createUtilityPlugin('gridRowEnd', [['row-end', ['gridRowEnd']]]),
gridRowStart: createUtilityPlugin('gridRowStart', [['row-start', ['gridRowStart']]], {
supportsNegativeValues: true,
}),
gridRowEnd: createUtilityPlugin('gridRowEnd', [['row-end', ['gridRowEnd']]], {
supportsNegativeValues: true,
}),

float: ({ addUtilities }) => {
addUtilities({
Expand Down
24 changes: 24 additions & 0 deletions tests/negative-prefix.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -360,3 +360,27 @@ test('addUtilities without negative prefix + variant + negative prefix in conten

expect(result.css).toMatchCss(css``)
})

test('negative col/row-start/end utilities', () => {
let config = {
content: [{ raw: html`<div class="-col-start-4 -col-end-4 -row-start-4 -row-end-4"></div>` }],
corePlugins: { preflight: false },
}

return run('@tailwind utilities;', config).then((result) => {
expect(result.css).toMatchCss(css`
.-col-start-4 {
grid-column-start: -4;
}
.-col-end-4 {
grid-column-end: -4;
}
.-row-start-4 {
grid-row-start: -4;
}
.-row-end-4 {
grid-row-end: -4;
}
`)
})
})
Loading