Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid over-extracting utilities from candidates with decimal values #13959

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

adamwathan
Copy link
Member

@adamwathan adamwathan commented Jul 5, 2024

Prevents candidates like px-1.5 from generating both the px-1.5 class and the px-1 class.

There's a chance that the inner matches regex we're throwing away here handles some other cases that aren't currently tested, but since they aren't tested I'm assuming it's not needed. We'll find out quickly from our users if they were and can fix it then :)

Fixes #13952 and #9354 and probably a bunch of other issues that have been opened for the same thing.

Prevent candidates like `px-1.5` from generating both the `px-1.5` class and the `px-1` class.
@adamwathan adamwathan merged commit 074736c into master Jul 5, 2024
13 checks passed
@adamwathan adamwathan deleted the avoid-overextracting-from-decimal-utilities branch July 5, 2024 18:46
@danielehrhardt
Copy link

@adamwathan all Angular Apps are broken with this PR, would be great if this could be fixed soon.
#14011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants