Always generate -webkit-backdrop-filter property #13997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
approved these changes
Jul 13, 2024
This was referenced Aug 7, 2024
This was referenced Sep 1, 2024
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all of the
backdrop-*utilities to always include the-webkit-backdrop-filtervendor prefixed property so that Tailwind isn't completely dependent on autoprefixer or Lightning CSS to produce these styles. We used to do this for-webkit-appearance: nonefor the same reason until browser support for the unprefixed property was solid.Safari didn't add support for unprefixed
backdrop-filteruntil Safari 18 (which isn't out yet at the time of this PR), so I think it makes sense to just bake this in. We do this in the v4 engine already which is targets more modern browsers than v3, so I think it makes sense to do in v3 as well:https://github.com/tailwindlabs/tailwindcss/blob/next/packages/tailwindcss/src/utilities.ts#L3262
Here's an example of where this bit someone in an important situation:
https://x.com/impatienceisav1/status/1811837511544803416