Normalize attribute selector for data-* and aria-* modifiers
#14037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi this is technically breaking. Though in practice it may not actually matter. I kinda doubt people are using this feature but today this candidate causes the div to be underlined: However, after this PR it won't. I think it's probably okay to ship as-is but we'll want to at least make note of this in case we need to follow it up with a fix (and check for |
|
@thecrypticace Hmm yes indeed. As you say, it's easy to catch this case and check for the valid flags if we want to. Let's for sure make a not though! |
RobinMalfait
changed the title
data- and aria- modifiersdata-* and aria-* modifiers
Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
philipp-spiess
added a commit
that referenced
this pull request
Jul 24, 2024
…4040) Fixes #14026 See #14037 for the v3 fix When translating `data-` and `aria-` modifiers with attribute selectors, we currently do not wrap the target attribute in quotes. This only works for keywords (purely alphabetic words) but breaks as soon as there are numbers or things like spaces in the attribute: ```html <div data-id="foo" class="data-[id=foo]:underline">underlined</div> <div data-id="f1" class="data-[id=1]:underline">not underlined</div> <div data-id="foo bar" class="data-[id=foo_bar]:underline">not underlined</div> ``` Since it's fairly common to have attribute selectors with `data-` and `aria-` modifiers, this PR will now wrap the attribute in quotes unless these are already wrapped. | Tailwind Modifier | CSS Selector | | ------------- | ------------- | | `.data-[id=foo]` | `[data-id='foo']` | | `.data-[id='foo']` | `[data-id='foo']` | | `.data-[id=foo_i]` | `[data-id='foo i']` | | `.data-[id='foo'_i]` | `[data-id='foo' i]` | | `.data-[id=123]` | `[data-id='123']` | --------- Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
RobinMalfait
approved these changes
Jul 24, 2024
This was referenced Aug 30, 2024
This was referenced Sep 1, 2024
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14026
See #14040 for the v4 fix
When translating
data-andaria-modifiers with attribute selectors, we currently do not wrap the target attribute in quotes. This only works for keywords (purely alphabetic words) but breaks as soon as there are numbers or things like spaces in the attribute:Since it's fairly common to have attribute selectors with
data-andaria-modifiers, this PR will now wrap the attribute in quotes unless these are already wrapped..data-[id=foo][data-id='foo'].data-[id='foo'][data-id='foo'].data-[id=foo_i][data-id='foo i'].data-[id='foo'_i][data-id='foo' i].data-[id=123][data-id='123']