Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabling dark mode globally #2530

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Conversation

adamwathan
Copy link
Member

This PR adds support setting dark to false in your config file to prevent dark mode variants from being generated.

Normally I would say just disable it individually for all of the core plugins where you have it enabled, but since we are going to enable it out of the box and it adds considerable file size and we already have a global config option for it, it seemed like a useful thing to support for people who don't care about dark mode and want their builds to purge a bit faster.

@adamwathan adamwathan merged commit 0feb064 into master Oct 9, 2020
@adamwathan adamwathan deleted the make-dark-disableable branch October 9, 2020 14:37
@frederikhors
Copy link
Contributor

This is missing in docs.

@adamwathan
Copy link
Member Author

All of dark mode is missing from the docs since it's still experimental 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants