Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary values + calc + theme with quotes #7462

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

thecrypticace
Copy link
Contributor

Arbitrary values when paired with calc + theme didn't work right if it used quotes. This was down to us not detecting it as a viable class candidate. I added a couple of regexes to match these and it not works as expected.

Basically:

  1. This already worked and still does: h-[calc(100%-theme(spacing.16))]
  2. However this didn't — but now does: h-[calc(100%-theme('spacing.16'))]
  3. It's the same for this: h-[calc(100%-theme("spacing.16"))]

Fixes #7309

@thecrypticace thecrypticace merged commit db475be into master Feb 14, 2022
@thecrypticace thecrypticace deleted the fix/theme-quotes branch February 14, 2022 20:44
tmattio added a commit to tmattio/opam-repository that referenced this pull request Apr 9, 2022
CHANGES:

### Fixed

- Remove opacity variables from `:visited` pseudo class ([tmattio/opam-tailwindcss#7458](tailwindlabs/tailwindcss#7458))
- Support arbitrary values + calc + theme with quotes ([tmattio/opam-tailwindcss#7462](tailwindlabs/tailwindcss#7462))
- Don't duplicate layer output when scanning content with variants + wildcards ([tmattio/opam-tailwindcss#7478](tailwindlabs/tailwindcss#7478))
- Implement `getClassOrder` instead of `sortClassList` ([tmattio/opam-tailwindcss#7459](tailwindlabs/tailwindcss#7459))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use theme() within calc() in arbitrary value
1 participant