Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate two different button resets to avoid too much specificity #8704

Closed
wants to merge 4 commits into from
Closed

Separate two different button resets to avoid too much specificity #8704

wants to merge 4 commits into from

Commits on Jun 22, 2022

  1. Separate two different button resets to avoid too much specificity 

     - Taking a look at https://github.com/sindresorhus/modern-normalize/blob/main/modern-normalize.css#L188, I think we should separate the style reset from the iOS Safari reset.  I don't think we need to target the style reset of background-image and background-color to [type=] as well as button.
 - This will make it so using tailwind with other libraries is a bit simpler than before, since the specificity  of [type=X] is fairly high compared to other selectors.
    @SupergreatAndrew
    SupergreatAndrew committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    31d3959 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2022

  1. Separate styles but keep them the same for button / [type='submit']

    @SupergreatAndrew
    SupergreatAndrew committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    8a1165b View commit details
    Browse the repository at this point in the history

  2. Update [type] selectors to target inputs instead of buttons 

     - Thinking about the reasoning behind the update for v3, I think this would work well for keeping styling the same between these two things (inputs of certain types and buttons), while at the same time not applying more specificity to buttons than intended (and accidentally targeting buttons since they overlap in usage of the type attribute).
    @SupergreatAndrew
    SupergreatAndrew committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    0f5270f View commit details
    Browse the repository at this point in the history

  3. Remove extra styles left over from first attempt

    @SupergreatAndrew
    SupergreatAndrew committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    de2e8f1 View commit details
    Browse the repository at this point in the history