Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when homeDir is not available #375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaykayehnn
Copy link

I encountered a crash when running live-server from a systemd service, and tracked the issue to loading the config from a user's home folder

var homeDir = process.env[(process.platform === 'win32') ? 'USERPROFILE' : 'HOME'];
var configPath = path.join(homeDir, '.live-server.json');
if (fs.existsSync(configPath)) {
var userConfig = fs.readFileSync(configPath, 'utf8');
assign(opts, JSON.parse(userConfig));
if (opts.ignorePattern) opts.ignorePattern = new RegExp(opts.ignorePattern);
}

In systemd services, the HOME variable is not present, which causes the issue.

This PR fixes it by verifying the variable is non-empty before loading a user's config.

@belauzas
Copy link

Hi @kaykayehnn I would like to use your PR for dead-server update, because this project seems to be abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants