Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate carsus atomic data repositories with carsus #366

Merged
merged 8 commits into from
Sep 15, 2023

Conversation

s-rathi
Copy link
Contributor

@s-rathi s-rathi commented Aug 20, 2023

Description 📝

This PR integrates the carsus-data-cmfgen, carsus-data-kurucz and carsus-data-nist to the carsus repository.

Type: 🎢 infrastructure

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

.github/workflows/carsus-data-repos-config.yml Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we are completely replaced Chianti with CMFGen data for TARDIS? @wkerzendorf

@andrewfullard andrewfullard self-requested a review August 31, 2023 14:56
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #366 (ecd156c) into master (275c383) will decrease coverage by 6.31%.
Report is 55 commits behind head on master.
The diff coverage is 50.75%.

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage   74.44%   68.13%   -6.31%     
==========================================
  Files          23       29       +6     
  Lines        2614     3534     +920     
==========================================
+ Hits         1946     2408     +462     
- Misses        668     1126     +458     
Files Changed Coverage Δ
carsus/io/chianti_/chianti_.py 85.80% <0.00%> (+19.36%) ⬆️
carsus/io/nndc/base.py 0.00% <0.00%> (ø)
carsus/io/nndc/ensdf.py 0.00% <0.00%> (ø)
carsus/io/nndc/parsers.py 0.00% <0.00%> (ø)
carsus/io/output/base.py 8.96% <8.42%> (-1.88%) ⬇️
carsus/io/atom_data_compare.py 12.97% <12.97%> (ø)
carsus/io/zeta.py 27.65% <16.66%> (-2.35%) ⬇️
carsus/io/nist/ionization.py 95.36% <83.33%> (-1.18%) ⬇️
carsus/io/cmfgen/base.py 87.14% <85.49%> (+3.14%) ⬆️
carsus/io/nuclear/nndc.py 88.13% <88.13%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atharva-2001 atharva-2001 merged commit 97442dd into tardis-sn:master Sep 15, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants