http/db: Bound concurrent DB queries #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arurao
added a commit
that referenced
this pull request
Jul 10, 2019
http/db: Bound concurrent DB queries (#1) * add per-auth concurrency-limiting middleware alerts: address mobile alerts controls bottom margin (#3) * increase toolbar margin on smaller screens * adjust whitespace width to the left of the alerts checkbox controls * slightly reduce alerts checkbox controls bottom margin on desktop fix ability to navigate back to the active alerts tab (#2) users: fix name validation for users search (#5) services: auto select service in alert form (#4) * rename ServiceOnCallDisplay to ServiceOnCallQuery * Add empty list message for on call users * Add space after EP name on a service * Fix prop names for alerts list show favorites snackbar and alert form * fix prop names in alert form and alert fab * revert linting change services: re-add route to view integration key docs (#6) * re-add route for integration key api documentation * use latest markdown component as used in details pages * update readme title and move email section to bottom * remove previously used markdown package * update markdown file to use a table for api parameter options * format markdown mailgun: fix signature errors (#7) * add mailgun config to harness * Return 400 on form-parse errors, 406 for mailgun * add mailgun smoketest * increase max req. body size from 32KiB to 256KiB auth: update default Auth.RefererURLs behavior (#8) * Change default referer behavior to same-host * don't overwrite config with empty object * fixed a couple integration tests * add flag to disable HTTPS redirect Templates (#10) * added issue templates docs: Add guides, update READMEs (#9) * Changes from old repo * adding screenshot * tweak to project description * Simplify dev setup documentation * resetdb: don't err if db doesn't exist * Cleanup contributing guidelines a bit * Update smoketest readme * add Dockerfile * getting started guide * dev setup guide * add mailgun section * add note about API-only mode * attempt to start postgres container on failure (fix dev issue) * shorten getting started intro * tweaks to postgres getting started info * add link to effective Go in CONTRIBUTING.md * add links to more info for tests * add go unit test example * update label query in README Co-Authored-By: Mitch Cimenski <mitch@m17ch.com> Co-Authored-By: Arundhati Rao <arao4@buffalo.edu> chore: update Go dependencies (#12) * update switchover code for pgx api changes * github package api update * use contrib package for jaeger tracing * update module files ui dependencies: webpack-dev-server upgrade to stable version (#11) * Update webpack-dev-server package.json dependency to stable version * revert lockfile changes that are unrelated to the webpack-dev-server * upgrade to latest webpack-dev-server version ui dependencies: upgrade material-ui and react (#13) * update mui and react dependencies * remove useNextVariants from the mui theme * fix grid spacing breaking changes * forward required refs to transition components * fix theme unit spacing breaking changes * update variant fab button to use fab component * fix issue with route expecting a function to render * fix material-select height issue with mui updates * update material-select to use a valid color prop on typography * update mui to the latest latest versions * update react-dom to latest release * update lockfile version of @hot-loader/react-dom * user explicit version for @hot-loader/react-dom * yarn install ui dependencies: material-ui-pickers update to @material-ui/pickers v3.1.0 (#14) * update to latest material-ui pickers package * update imports * use explicit version of dependency and update package name in webpack config * yarn lock update docker: fix default listen address in container (#17) ui dependencies: non-breaking change package updates (#18) * update babel and material ui * upgrade mui lab * package patch updates * package minor updates * webpack upgrade fix to fs * update node props to allow css-loader to properly build when starting the app * revert webpack config changes * major package upates with no relevant breaking changes * remove some unused packages * update react-redux and connected-react-router the latest updates of these two packages are dependent on eachother being up to date simultaneously because of Redux utilizing React's context API * nonbreaking package upgrades from over the weekend * fix chance's word props min/max not actually existing * this.context.router no longer supported, use withRouter to get history prop * update lockfile * make check contactmethod: allow UK (+44) numbers (#22) * Add support for UK country code (+44) * Add test cases for UK numbers * Reference the UK for the Supported Country Code ui-dependencies: organize package.json dependencies (#20) * remove some unused packages and organize package.json * save lockfile * re-add required types packages as dev dependencies * add graphql as required dev dependency make fake slack creds look more fake (#32) Replacing fake Slack credentials with zeros instead of random so they don't appear to be real ones. services: favorites test code improvements (#31) * add favorite support to `createService` mutation * create new services as favorites * create `favorites.ts` test suite Co-authored-by: Anderson Day <dayander@msu.edu> Co-authored-by: Katy <kmm5278@rit.edu> switchover: hardening & refactor instrumentation (#23) * fix migration template typo * automatic trigger generation * handle pgx migration errors * make no-pause-api and extra sync default behavior * proper db identification/validation * add progress for long operations * normalize table scanning * cancelation fixes * first pass at switchover docs * include version in DB application_name * status information improvements alertlog: graphql2 endpoint (#16) implementing recentEvents as a field for an alert's log entries. ep step: allow user selection when Slack is disabled (#36) * update cypress * add failing test for ep user selection * fix the bug rotations: add user favorites support (#27) * Added `QuerySetFavoriteButton` component for dynamic favoriting * Added the ability to favorite rotations alerts: add `createAlert` mutation (#37) * gql2 createAlert mutation and smoketest dev: easily run integration tests by cli (#39) * Added `--log-errors-only` flag to the backend * Added `make cy-wide-prod-run` and `make cy-mobile-prod-run` commands for running tests * Added `make check-all` that runs all integration & smoketests, as well as `make check` * Updated the runjson tool to support env-params * Use chrome by default to run tests allow 10-digit sections in slack tokens (#41) schedules: add user favorites support (#26) * Favorites icon for schedules * New migration and schema changes * Tests for setting/finding favorites; integration with shared favorites component * Wizard favorites schedules created automatically and new schedules are favorited on creation. Wizard unit test updated accordingly config: loosen key validation & guide updates (#44) * allow all external config strings to be ASCII * update docs for new Mailgun UI Search: update validation for search strings containing spaces (#47) * new search validation function * replacing text validation to search validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an upper bound to the number of concurrent DB queries for a given auth type/id/instance. The approach taken is to limit concurrent HTTP request processing based on the request's permission info.
Limits:
It intends to be a relatively simple/interim approach to preventing a single user, service, or integration key from saturating the connection pool of a single GoAlert instance.
Out of Scope: