Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alerts: add email smtp support for outgoing alerts #1185

Merged
merged 20 commits into from
Jan 14, 2021
Merged

Conversation

arurao
Copy link
Contributor

@arurao arurao commented Jan 13, 2021

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Added functionality for sending outgoing alerts via email smtp. A new user contact method type EMAIL has been introduced. Users can now add their email address as a contact method in the profile page and receive alert emails.
The SMTP server details can be added via the Admin page, including details like sender email address.

Which issue(s) this PR fixes:
Closes #45

Describe any introduced user-facing changes:
Admins can now add smtp server details via the admin page. Users can configure their email address as a contact method via the profile page.

@arurao arurao changed the title Smtp support alerts: add email smtp support for outgoing alerts Jan 13, 2021
@m17ch m17ch self-requested a review January 14, 2021 16:05
m17ch
m17ch previously approved these changes Jan 14, 2021
Copy link
Contributor

@m17ch m17ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@mastercactapus mastercactapus merged commit 1e4b227 into master Jan 14, 2021
@mastercactapus mastercactapus deleted the smtp-support branch January 14, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add alerting (outgoing) via email (smtp)
3 participants