Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to mark alert usefulness #3107

Closed
wants to merge 19 commits into from
Closed

add ability to mark alert usefulness #3107

wants to merge 19 commits into from

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented Jun 20, 2023

Description:

  • Adds the ability to mark an alert as useful or not. If not useful, a text field will appear with the option to add why.
  • Moves the alert update buttons to the left, making them primary contained text buttons instead of secondary icon buttons.

Which issue(s) this PR fixes:

Out of Scope:

  • Updating alert metrics table & graph to include rating info
  • Possibly list recent un-rated alerts somewhere

Screenshots:

Neutral:

neutral

Tooltip:

tooltip

Marked as useful:

up

Marked as not useful:

down

Marked as not useful, with note:

with note

Describe any introduced API changes:

  • Added type feedback to alert with the fields sentiment and note

@mastercactapus
Copy link
Member

mastercactapus commented Jun 23, 2023

I really like how the layout turned out, we started talking about it now that we have the visual, and I took some notes on the discussion:

  • Reconsidering the design and functionality of thumbs up/down buttons:
    • Add examples within the tooltip to make the function of the buttons more clear.
    • Suggest adding text to the page to signify that the purpose of these buttons is to gauge alert actionability.
    • Could potentially use a header above the button group with additional explanatory text.
    • Another option is to place "actionable?" text above the buttons with more detailed information remaining in the tooltip.
  • Proposing a new feedback method:
    • A single "Problem?" button leading to a dropdown menu dialog with these options:
      • False-positive
      • Resolved itself
      • Wasn't actionable
      • Poor details
      • Other (with custom entry field)
  • Plan to keep the API simple by storing these feedback responses as "notes" in the database.
  • In a later version (post-MVP), consider introducing functionality to filter graphs by "problematic alerts" and potentially further filter by specific "notes" values (e.g., "false positive").

The current leaning is towards the single "Problem?" button and focusing on the negative feedback. One of the bits that came up was when things are working well (i.e., all alerts are valuable/actionable), there's may not be much reason to rate them anymore.

Deciding to wait until next week to continue the discussion.

@Forfold
Copy link
Contributor Author

Forfold commented Jun 27, 2023

Oh I thought this was the final design decision @mastercactapus. Sounds good, I'm back in office today.

@target target deleted a comment from github-actions bot Jun 27, 2023
@target target deleted a comment from github-actions bot Jun 27, 2023
@target target deleted a comment from github-actions bot Jun 27, 2023
@target target deleted a comment from github-actions bot Jun 27, 2023
@target target deleted a comment from github-actions bot Jun 27, 2023
@Forfold Forfold marked this pull request as draft June 27, 2023 19:14
@target target deleted a comment from github-actions bot Jun 27, 2023
@target target deleted a comment from github-actions bot Jun 27, 2023
@target target deleted a comment from github-actions bot Jun 27, 2023
@Forfold
Copy link
Contributor Author

Forfold commented Jun 27, 2023

github actions highkey annoying

@Forfold
Copy link
Contributor Author

Forfold commented Jun 28, 2023

Closing as this is now in-development again. Will re-open as a new PR when done

@Forfold Forfold closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to Record Alert Usefulness (noise)
2 participants