Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

view noisy alert count on service alert metrics graph #3161

Merged
merged 14 commits into from
Jul 19, 2023
Merged

view noisy alert count on service alert metrics graph #3161

merged 14 commits into from
Jul 19, 2023

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented Jul 11, 2023 •
edited by KatieMSB
Loading

Description:

  • Adds the ability to view closed alerts that have been marked as noise on the alert metrics graph for any given service
  • Adds the helper text "Showing data for closed alerts" above the alert metrics graph (as only closed alerts are reported)
  • Updates the escalated alerts metric to present as a line instead of a stacked bar

Which issue(s) this PR fixes:

Screenshots:
Screenshot 2023-07-18 at 3 37 26 PM

@Forfold Forfold marked this pull request as draft July 11, 2023 18:05
@Forfold Forfold marked this pull request as ready for review July 12, 2023 15:10
@github-actions github-actions bot added size/s and removed size/xl labels Jul 12, 2023
@mastercactapus
Copy link
Member

Should both escalated and noise values be lines, with only the total alert count being the bar?

@Forfold
Copy link
Contributor Author

Forfold commented Jul 13, 2023

@mastercactapus that would make the most sense. I left the graph as is for minimal changes

@github-actions github-actions bot added size/m and removed size/s labels Jul 18, 2023
KatieMSB and others added 2 commits July 18, 2023 11:10
@KatieMSB
generate sqlc
06a8ec8
@leyasalazar
update escalated count bar to line
b0dce3e 
>
>
Co-authored-by: KatieMSB <katriannasb@gmail.com>
@KatieMSB KatieMSB removed the blocked label Jul 18, 2023
@mastercactapus
Copy link
Member

mastercactapus commented Jul 19, 2023 •
edited
Loading

Something is mismatched: the number of escalated alerts shouldn't be able to be higher than the total number of alerts.
image

Edit: this has been fixed

@mastercactapus mastercactapus merged commit aa84612 into master Jul 19, 2023
6 checks passed
@mastercactapus mastercactapus deleted the feedback-graph branch July 19, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@ethan-haynes ethan-haynes ethan-haynes approved these changes

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to Report Alert Usefulness (noise)
5 participants
@Forfold @mastercactapus @ethan-haynes @KatieMSB @leyasalazar