Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add smoke test for on call notification webhooks #3162

Merged
merged 2 commits into from
Jul 12, 2023
Merged

feat: add smoke test for on call notification webhooks #3162

merged 2 commits into from
Jul 12, 2023

Conversation

allending313
Copy link
Collaborator

@allending313 allending313 commented Jul 11, 2023 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Added additional smoke test ensuring that webhooks can receive notifications from a schedule's on-call notification rule.

mastercactapus
mastercactapus requested changes Jul 12, 2023
View reviewed changes
test/smoke/webhookoncall_test.go Outdated Show resolved Hide resolved
test/smoke/webhookoncall_test.go Outdated Show resolved Hide resolved
Forfold
Forfold approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mastercactapus mastercactapus merged commit a9f0120 into master Jul 12, 2023
6 checks passed
@mastercactapus mastercactapus deleted the webhook-smoke-test branch July 12, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@Forfold Forfold Forfold approved these changes

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allending313 @mastercactapus @Forfold