Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: batch js updates #3298

Merged
merged 13 commits into from
Sep 21, 2023
Merged

chore: batch js updates #3298

merged 13 commits into from
Sep 21, 2023

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Sep 21, 2023 •
edited
Loading

Description:
This PR updates most javascript dependencies to their latest versions.

Out of Scope:

Additional Info:

  • yarn was updated to 3.6.3 to fix some issues
  • CreateAlertConfirm was refactored to work better with the typescript updates
  • MaterialSelect added missing argument types added
  • HeartbeatMonitorForm had a missing argument type added
  • app/urlql.ts was updated due to a nodejs type name change
  • graphql explorer app was udpated to use createRoot
  • yarn.lock was regenerated due to a large number of duplicate packages (which broke typescript in many places)

KatieMSB
KatieMSB previously approved these changes Sep 21, 2023
View reviewed changes
KatieMSB
KatieMSB previously approved these changes Sep 21, 2023
View reviewed changes
andrewbenington
andrewbenington reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@andrewbenington andrewbenington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency, should stable be replaced with $(YARN_VERSION) here?

goalert/Makefile

Lines 192 to 193 in b25e705

.yarn/releases/yarn-$(YARN_VERSION).cjs:
yarn set version stable || $(MAKE) yarn

@mastercactapus mastercactapus merged commit 69adbd5 into master Sep 21, 2023
7 checks passed
@mastercactapus mastercactapus deleted the js-updates-safe-sept-2023 branch September 21, 2023 21:58
allending313 pushed a commit that referenced this pull request Sep 27, 2023
@mastercactapus
chore: batch js updates (#3298)
f5e81d7 
* use createRoot

* upgrade yarn

* add missing type

* prettier

* refactor CreateAlertConfirm for ts update

* remove duplicate react types def.

* fix callback types

* upgrade remark, urql, wonka

* remove duplicate package

* regen lockfile

* update timer type

* revert remark-gfm update

* set yarn version to makefile version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatieMSB KatieMSB KatieMSB approved these changes

@andrewbenington andrewbenington andrewbenington approved these changes

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mastercactapus @KatieMSB @andrewbenington