Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services: update query to return maintenance_expires_at #3341

Merged
merged 1 commit into from
Oct 5, 2023
Merged

services: update query to return maintenance_expires_at #3341

merged 1 commit into from
Oct 5, 2023

Conversation

KatieMSB
Copy link
Collaborator

@KatieMSB KatieMSB commented Oct 5, 2023

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Currently the services() query returns null for maintenance_expires_at for all services, this pr updates the search query to include it in the return.

@KatieMSB KatieMSB merged commit cc7c496 into master Oct 5, 2023
7 checks passed
@KatieMSB KatieMSB deleted the services-return-maintenance branch October 5, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@ethan-haynes ethan-haynes ethan-haynes approved these changes

Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KatieMSB @mastercactapus @ethan-haynes