Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/urql: transition to urql and use suspense to load user details #3430

Merged
merged 3 commits into from
Nov 8, 2023
Merged

ui/urql: transition to urql and use suspense to load user details #3430

merged 3 commits into from
Nov 8, 2023

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented Nov 7, 2023

Description:

  • Converts queries in UserContactMethodList and UserNotificationRuleList from @apollo/client to urql
  • Uses a suspense context for the queries in UserDetails, UserContactMethodList, and UserNotificationRuleList

Which issue(s) this PR fixes:

Describe any introduced user-facing changes:

  • User details should load all at once after a centered spinner

Additional Info:

  • yarn.lock got updated when I ran make start

@github-actions github-actions bot added the size/m label Nov 7, 2023
@Forfold Forfold mentioned this pull request Nov 7, 2023
Open
76 tasks
tony-tvu
tony-tvu approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@tony-tvu tony-tvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Forfold Forfold merged commit 5c588e1 into master Nov 8, 2023
7 checks passed
@Forfold Forfold deleted the userdetails-urql branch November 8, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatieMSB KatieMSB KatieMSB approved these changes

@tony-tvu tony-tvu tony-tvu approved these changes

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Forfold @KatieMSB @tony-tvu