Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user: update User CM to use destinations #3658

Closed
wants to merge 42 commits into from

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented Feb 6, 2024

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR updates the UserContactMethod form, create, and edit dialogs to use destinations when the experimental flag is set make start EXPERIMENTAL=dest-types.

Which issue(s) this PR fixes:
part of #2639

Out of Scope:

  • moved destinationTypes to RequireConfig provider

Screenshots:
Screenshot 2024-02-06 at 5 01 59 PM
Screenshot 2024-02-06 at 5 02 10 PM
Screenshot 2024-02-06 at 5 09 29 PM
Screenshot 2024-02-06 at 5 09 19 PM
Screenshot 2024-02-06 at 5 09 10 PM

Describe any introduced user-facing changes:
N/A, behavior should be the same as today, with the exception of Slack now using the team/workspace icon instead of the generic slack icon.

Describe any introduced API changes:

  • adds supportsStatusUpdates and statusUpdatesRequired to DestinationTypeInfo
  • add dest to UserContactMethod for destination info

Additional Info:
n/a

TonyTVu and others added 30 commits January 11, 2024 16:11
e