Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users: use generic destinations for user CM create dialog component #3664

Merged
merged 39 commits into from
Feb 22, 2024

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented Feb 9, 2024

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR updates the UserContactMethod create and dialog components to use generic destinations when the experimental flag is set make start EXPERIMENTAL=dest-types.

Which issue(s) this PR fixes:
part of #2639

Out of Scope:
N/A

Screenshots:
Screenshot 2024-02-09 at 12 15 38 PM
Screenshot 2024-02-09 at 12 15 30 PM
Screenshot 2024-02-09 at 12 15 20 PM
Screenshot 2024-02-09 at 12 15 11 PM
Screenshot 2024-02-09 at 12 14 57 PM

Describe any introduced user-facing changes:
N/A, behavior should be the same as today.

Describe any introduced API changes:
N/A

Additional Info:
N/A

Copy link
Member

@mastercactapus mastercactapus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a couple issues when functionally testing:

@mastercactapus
Copy link
Member

For the error stuff I think that's going to require a bit of extra thought; working on dest-error-api branch

@tony-tvu
Copy link
Collaborator Author

tony-tvu commented Feb 9, 2024

For the error stuff I think that's going to require a bit of extra thought; working on dest-error-api branch

Sounds good. Thanks for pushing up the fixes to this branch!

@github-actions github-actions bot added size/l and removed size/xl labels Feb 20, 2024
@github-actions github-actions bot added size/xl and removed size/l labels Feb 20, 2024
web/src/app/util/errutil.ts Outdated Show resolved Hide resolved
web/src/app/util/errutil.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/l and removed size/xl labels Feb 21, 2024
mastercactapus
mastercactapus previously approved these changes Feb 22, 2024
@mastercactapus mastercactapus changed the title users: use generic destinations for user CM create and edit dialog components users: use generic destinations for user CM create dialog component Feb 22, 2024
mastercactapus
mastercactapus previously approved these changes Feb 22, 2024
@github-actions github-actions bot added size/xl and removed size/l labels Feb 22, 2024
@mastercactapus mastercactapus merged commit 1c28326 into master Feb 22, 2024
7 checks passed
@mastercactapus mastercactapus deleted the user-CM-create-edit-dest branch February 22, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants