Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users: use generic destinations for User Notification Rule List component #3701

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

ethan-haynes
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR updates the UserNotificationRuleList component to use generic destinations when the experimental flag is set make start EXPERIMENTAL=dest-types.

Which issue(s) this PR fixes:
part of #2639

Out of Scope:
N/A

Screenshots:
Screenshot 2024-02-22 at 1 03 47 PM

Describe any introduced user-facing changes:
Once experimental flag dest-types is no longer required, user contact methods on the profile page will display new label singular values.

Describe any introduced API changes:
N/A

Additional Info:
N/A

@tony-tvu tony-tvu merged commit 4d43e92 into master Feb 23, 2024
7 checks passed
@tony-tvu tony-tvu deleted the user-note-rule-list-dest branch February 23, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants