Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dest: use destinations for EP step edit dialog #3772

Merged
merged 9 commits into from
Mar 27, 2024

Conversation

allending313
Copy link
Collaborator

@allending313 allending313 commented Mar 25, 2024

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR adds an escalation policy step edit dialog component which utilizes generic destinations when experimental flag is set to dest-types.

Which issue(s) this PR fixes:
part of #2639

Describe any introduced user-facing changes:
UI for ep step edit dialog will be simplified allowing users to select which destination they want to edit one at a time via chips and a single dropdown.

@mastercactapus mastercactapus marked this pull request as ready for review March 26, 2024 19:28
@ethan-haynes ethan-haynes merged commit e61639f into master Mar 27, 2024
9 checks passed
@ethan-haynes ethan-haynes deleted the ep-step-edit-dialog-dest-ui branch March 27, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants