Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urql: Convert UserList to use urql #3823

Merged
merged 11 commits into from
Apr 26, 2024
Merged

urql: Convert UserList to use urql #3823

merged 11 commits into from
Apr 26, 2024

Conversation

mastercactapus
Copy link
Member

Description:
This PR takes a composable approach with a ListPageControls component with two slots:

  • list The list of items to render (likely FlatList)
  • search Optional search bar (likely the <Search> component)

Which issue(s) this PR fixes:
Part of #3240

Out of Scope:

  • Moving the cursor logic into a re-usable hook will be done separately.

Describe any introduced user-facing changes:
N/A UI behavior is identical

Describe any introduced API changes:
N/A

KatieMSB
KatieMSB previously approved these changes Apr 24, 2024
KatieMSB
KatieMSB previously approved these changes Apr 25, 2024
allending313
allending313 previously approved these changes Apr 25, 2024
KatieMSB
KatieMSB previously approved these changes Apr 25, 2024
@mastercactapus mastercactapus merged commit 13e5367 into master Apr 26, 2024
7 checks passed
@mastercactapus mastercactapus deleted the users-list-urql branch April 26, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants