Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urql: move schedule override list to ListPageControls #3853

Merged
merged 2 commits into from
Jul 3, 2024
Merged

urql: move schedule override list to ListPageControls #3853

merged 2 commits into from
Jul 3, 2024

Conversation

mastercactapus
Copy link
Member

Description:
Updates ScheduleOverrideList to use ListPageControls instead of QueryList

Which issue(s) this PR fixes:
Part of #3240

@github-actions github-actions bot added the size/m label May 8, 2024
@Forfold Forfold changed the title urql: move schedule override list to urql urql: move schedule override list to ListPageControls May 9, 2024
allending313
allending313 previously approved these changes May 13, 2024
View reviewed changes
@Forfold
Copy link
Contributor

Forfold commented May 20, 2024

Failing test:

Schedules
Wide
Schedule Overrides
should edit and delete an override:

@github-actions github-actions bot added size/xl and removed size/m labels Jul 2, 2024
@allending313 allending313 force-pushed the schedule-overrides-rm-querylist branch from 7139647 to df8d485 Compare July 2, 2024 21:50
@allending313 allending313 force-pushed the schedule-overrides-rm-querylist branch from df8d485 to 16e7ae6 Compare July 2, 2024 21:58
@github-actions github-actions bot added size/m and removed size/xl labels Jul 2, 2024
@allending313
Copy link
Collaborator

@mastercactapus accidentally messed up the merge from master oops, thanks for the cleanup!

Forfold
Forfold approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: variable names could be better

@Forfold Forfold merged commit 58b2b8b into master Jul 3, 2024
7 checks passed
@Forfold Forfold deleted the schedule-overrides-rm-querylist branch July 3, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

@allending313 allending313 allending313 approved these changes

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mastercactapus @Forfold @allending313