Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uik: Add pending_signals table #3959

Merged
merged 8 commits into from
Jul 2, 2024
Merged

uik: Add pending_signals table #3959

merged 8 commits into from
Jul 2, 2024

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Jul 2, 2024

Description:

  • Fixes NullDestV1 JSON
  • Enabled webhook and email as dynamic actions (univ keys exp. flag)
  • refactors UIK to result in pending_signals (when not webhook or alert)
  • adds limits for pending per service and pending per service, per dest

Out of Scope:

  • Engine module for inserting into outgoing_messages and sending

Additional Context:

For validation start with make start EXPERIMENTAL=univ-keys

Create a UIK with a rule and/or default actions:

  • Alert actions should result in an alert
  • Webhook actions will result in an immediate request
  • Email actions will result in a row being created in pending_signals with the rendered params

- Introduced PendingSignal struct and related DB schema
- Defined and imposed new limits for pending signals
- Added new signal message types, enums, and SQL queries
- Implemented action channel verification
- Revised existing code to handle new signal message types and limits
- Compiled and executed conditional rules for actions
- Added `IsDynamicAction` and `DynamicParams` to email and webhook destinations for flexible parameter handling
- Removed unused `ActionResult` struct from integration key module
@github-actions github-actions bot added the size/l label Jul 2, 2024
integrationkey/config.go Show resolved Hide resolved
@mastercactapus mastercactapus merged commit a0497eb into master Jul 2, 2024
7 checks passed
@mastercactapus mastercactapus deleted the pending-signals-tbl branch July 2, 2024 18:47
allending313 pushed a commit that referenced this pull request Jul 2, 2024
* Add signal message handling and enforce limits

- Introduced PendingSignal struct and related DB schema
- Defined and imposed new limits for pending signals
- Added new signal message types, enums, and SQL queries
- Implemented action channel verification
- Revised existing code to handle new signal message types and limits
- Compiled and executed conditional rules for actions

* revert version change

* Enhance email and webhook destination configuration

- Added `IsDynamicAction` and `DynamicParams` to email and webhook destinations for flexible parameter handling
- Removed unused `ActionResult` struct from integration key module

* regen

* fix dest creation

* drop funcs on migrate down

* gen

* remove limit rows on migrate down
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants