feat: only trigger UTXO scanning when a new block event is received #3620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the UTXO scanner task was triggered on an interval. This PR updates this process to rather be triggered only when an existing task is not running and new Block event is received from the wallet Base Node monitoring service. It is only when this event is received when we know there will be new block data to scan. A new event is added to the Base Node Monitoring Service that only fires when a new block is detected to be used in the above functionality The Utxo Scanner is also refactored into separate files. To help in the review I have highlighted the new code below An unrelated bug is also fixed with handling of the wallet public address in the Console Wallet that broke the wallet.
stringhandler
approved these changes
Nov 26, 2021
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Nov 26, 2021
* development: feat: only trigger UTXO scanning when a new block event is received (tari-project#3620)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Dec 6, 2021
* development: (29 commits) fix(pruned mode)!: prune inputs, allow horizon sync resume and other fixes (tari-project#3521) feat!: sending one-sided transactions in wallet_ffi (tari-project#3634) fix: use json 5 for tor identity (regression) (tari-project#3624) test: add operation_id to log messages (tari-project#3633) fix!: multiple monerod addresses in tari merge mining proxy (tari-project#3628) fix: get-peer command works with public key again (tari-project#3636) fix!: separate peer seeds to common.network (tari-project#3635) test: removed stress test log target (tari-project#3631) feat: removed transaction validation redundant events (tari-project#3630) feat: improve wallet responsiveness (tari-project#3625) feat: add bulletproof rewind profiling (tari-project#3618) fix!: console wallet grpc_console_wallet_addresss config (tari-project#3619) test: increase timeout in cucumber (tari-project#3621) chore: change status line (tari-project#3610) feat!: add tcp bypass settings for tor in wallet_ffi (tari-project#3615) feat: only trigger UTXO scanning when a new block event is received (tari-project#3620) feat: implement dht pooled db connection (tari-project#3596) feat: add page for detailed mempool in explorer (tari-project#3613) chore: add pub key in the dailes notify (tari-project#3612) feat: display network for console wallet (tari-project#3611) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the UTXO scanner task was triggered on an interval. This PR updates this process to rather be triggered only when an existing task is not running and new Block event is received from the wallet Base Node monitoring service. It is only when this event is received when we know there will be new block data to scan.
A new event is added to the Base Node Monitoring Service that only fires when a new block is detected to be used in the above functionality
The Utxo Scanner is also refactored into separate files. To help in the review I have highlighted the new code below
An unrelated bug is also fixed with handling of the wallet public address in the Console Wallet that broke the wallet.
How Has This Been Tested?
manually and by CI