fix(comms): dial if connection is not connected #5223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
previously approved these changes
Mar 7, 2023
|
I changed it because it seemed to be a mistake. Perhaps a comment on the reasoning will prevent someone doing the same |
|
There is no reason really at the moment. We could just remove disconnected connections. The thinking all those years ago (which could still apply) is you could have a UI that refreshes, showing recently disconnected/failed to dial connections. Currently we only have list-connections which only shows connected connections. |
stringhandler
previously approved these changes
Mar 7, 2023
stringhandler
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug where recently disconnected connections do not get redialled
Motivation and Context
The connectivity manager pool maintains a list of connections including recently disconnected. These are cleared out periodically. The connectivity manager should not return disconnected connections to the caller.
How Has This Been Tested?
Manually: Connection is dialled when pool says the connection is not connected.