Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: hazop code review #6012

Merged
merged 3 commits into from
Dec 8, 2023
Merged

chore: hazop code review #6012

merged 3 commits into from
Dec 8, 2023

Conversation

SWvheerden
Copy link
Collaborator

@SWvheerden SWvheerden commented Dec 5, 2023 •
edited
Loading

Description

Changes from hazop code review

Tested manually

@ghpbot-tari-project ghpbot-tari-project added the CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. label Dec 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Test Results (CI)

1 261 tests   1 261 ✔️  12m 10s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit 52f5950.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Dec 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Test Results (Integration tests)

  2 files  11 suites   12m 38s ⏱️
28 tests 25 ✔️ 0 💤 3 ❌
32 runs  27 ✔️ 0 💤 5 ❌

For more details on these failures, see this check.

Results for commit 52f5950.

♻️ This comment has been updated with latest results.

@SWvheerden SWvheerden force-pushed the sw_review branch 3 times, most recently from 45ed4e7 to 4485a2c Compare December 8, 2023 09:23
@SWvheerden
review
7d50bf0 
fix ffi tests

fix

fix write

more fix

fix

more
hansieodendaal
hansieodendaal approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Dec 8, 2023
@SWvheerden SWvheerden merged commit 1193399 into tari-project:development Dec 8, 2023
12 of 14 checks passed
@SWvheerden SWvheerden deleted the sw_review branch December 8, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansieodendaal hansieodendaal hansieodendaal approved these changes

Assignees
No one assigned
Labels
CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWvheerden @hansieodendaal @ghpbot-tari-project