Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove user agent config option #6320

Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

Removes the user-controlled user_agent field from the config and makes this a coded option only.

Motivation and Context

This field is used by the application to report its name to the network. By default for the desktop and mobile apps this option is filled in by the application and reports the name and version of the application. This is very helpful for the network to decern whom they are connection to.

Leaving this option to user change, makes it very easy to remove this option on an individual bases. Currently Launchpad already does this and only reports like follows:

d59a25f5a6855360364af9c2c9 | 02b0d0e37aaded4eac745608fdd6c08ceb06209a4ef5af807560f8fb14b36477 | /onion3/5uatfvtqxoo553k5x7iuel7ezkl5y7c7zy7vhyd3fo24s2yfzepexfid:18141 | Outbound  | 8h 45m 34s   | Launchpad base node        | height: 39379, hnd: 1, ss: 2, rpc: 0 
e9f94287e9893c4934f89edce7 | 826eda735986db5e57b3fd0342f0d9feebacae9329dc40ee74abf20c1d21f46d | /ip4/54.78.252.60/tcp/18189                                            | Outbound  | 10h 31m 52s  | tari/basenode/1.0.0-rc.8   | height: 39378, hnd: 1, ss: 2, rpc: 0 

Although this does not stop a user from changing this field, it lifts the barrier to do this by requiring code changes.

Breaking Changes

Removes config option.

Copy link

github-actions bot commented May 6, 2024

Test Results (CI)

    3 files    120 suites   37m 53s ⏱️
1 277 tests 1 277 ✅ 0 💤 0 ❌
3 823 runs  3 823 ✅ 0 💤 0 ❌

Results for commit 085dc5b.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels May 6, 2024
Copy link

github-actions bot commented May 6, 2024

Test Results (Integration tests)

 2 files  11 suites   23m 38s ⏱️
33 tests 30 ✅ 0 💤 3 ❌
38 runs  32 ✅ 0 💤 6 ❌

For more details on these failures, see this check.

Results for commit 085dc5b.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label May 6, 2024
@SWvheerden SWvheerden merged commit 6b21e05 into tari-project:development May 6, 2024
14 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_remove_user_agent_config branch May 7, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants