Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default message tag #6355

Merged
merged 1 commit into from
May 27, 2024

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented May 27, 2024

Description

Add a default message tag to FinalSendMessageParams. This enables the tracing of ping-pong and other messages across nodes.

Motivation and Context

How Has This Been Tested?

System-level tests.

What process can a PR reviewer use to test or verify this change?

Review code.

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Copy link

Test Results (CI)

    3 files    120 suites   35m 31s ⏱️
1 275 tests 1 275 ✅ 0 💤 0 ❌
3 817 runs  3 817 ✅ 0 💤 0 ❌

Results for commit df6affb.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels May 27, 2024
Copy link

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   31m 31s ⏱️ + 31m 31s
33 tests +33  31 ✅ +31  0 💤 ±0  2 ❌ +2 
36 runs  +36  33 ✅ +33  0 💤 ±0  3 ❌ +3 

For more details on these failures, see this check.

Results for commit df6affb. ± Comparison against base commit bc2ac4c.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label May 27, 2024
@SWvheerden SWvheerden merged commit ef387d7 into tari-project:development May 27, 2024
15 of 17 checks passed
@hansieodendaal hansieodendaal deleted the ho_message_tag branch June 19, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants