Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wallet address deserialize #6428

Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

Fixes single address deserialize.

Motivation and Context

Its possible for the single address to be as small as 45 chars.

How Has This Been Tested?

Fuzz testing

Copy link

github-actions bot commented Jul 24, 2024

Test Results (CI)

    3 files    120 suites   36m 48s ⏱️
1 295 tests 1 295 ✅ 0 💤 0 ❌
3 877 runs  3 877 ✅ 0 💤 0 ❌

Results for commit f17a2ca.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jul 24, 2024
Copy link

Test Results (Integration tests)

 2 files  11 suites   24m 18s ⏱️
35 tests 34 ✅ 0 💤 1 ❌
36 runs  35 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit a828d43.

@SWvheerden SWvheerden merged commit 1ffce47 into tari-project:development Jul 24, 2024
12 checks passed
@SWvheerden SWvheerden deleted the sw_fix_address_deserialize branch July 24, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants