feat: check encumbrance later #6457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 123 suites 41m 44s ⏱️ Results for commit be4effd. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 1 errors 9 suites 11m 49s ⏱️ For more details on these parsing errors and failures, see this check. Results for commit be4effd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
move the encumbrance check to later in the send process
Motivation and Context
If we have this encumbrance check earlier, the wallet might encounter an error and leave some outputs locked.
How Has This Been Tested?
manual