Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: randomX on mac x86 #6559

Merged
merged 2 commits into from
Sep 12, 2024
Merged

fix: randomX on mac x86 #6559

merged 2 commits into from
Sep 12, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Randomx on Mac using x86 fails with the recommended flags and requires fallback to the default flags.

@SWvheerden SWvheerden requested a review from a team as a code owner September 12, 2024 13:40
@SWvheerden SWvheerden changed the title fix: randomx on mac x86 fix: randomX on mac x86 Sep 12, 2024
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 12, 2024
@brianp brianp self-requested a review September 12, 2024 13:47
brianp
brianp approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is exactly what I thought it would be, but didn't realize we were "recovering" from the error.

@SWvheerden SWvheerden merged commit a22ae35 into development Sep 12, 2024
16 checks passed
@SWvheerden SWvheerden deleted the test-randomx_x86 branch September 12, 2024 13:55
SWvheerden added a commit to SWvheerden/tari that referenced this pull request Sep 12, 2024
@SWvheerden
fix: randomX on mac x86 (tari-project#6559)
2278b3f 
Description
---
Randomx on Mac using x86 fails with the recommended flags and requires
fallback to the default flags.
@SWvheerden SWvheerden mentioned this pull request Sep 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianp brianp brianp approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWvheerden @brianp @ghpbot-tari-project