Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add ability to encrypt seed words #6569

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

allow the use of encrypted seed words.

@ghpbot-tari-project ghpbot-tari-project added the CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. label Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

Test Results (CI)

    3 files    129 suites   34m 17s ⏱️
1 323 tests 1 323 ✅ 0 💤 0 ❌
3 967 runs  3 967 ✅ 0 💤 0 ❌

Results for commit 8f456bd.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

Test Results (Integration tests)

36 tests   36 ✅  14m 54s ⏱️
11 suites   0 💤
 2 files     0 ❌

Results for commit 8f456bd.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from fixing tests, one functional use comment, otherwise it seems fine.

hansieodendaal
hansieodendaal previously approved these changes Sep 20, 2024
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Sep 20, 2024
@ghpbot-tari-project ghpbot-tari-project added the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Sep 20, 2024
@SWvheerden SWvheerden merged commit d03d162 into tari-project:development Sep 20, 2024
17 checks passed
@SWvheerden SWvheerden deleted the sw_askforassword branch September 20, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants