Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for variables in query parameters #176

Merged
merged 2 commits into from
May 12, 2022

Conversation

viernullvier
Copy link
Contributor

Context

Passing variables in the query string already seems to be accounted for in the codebase, but it's currently not working: Even though _get_response receives the variables, it's not decoding them as JSON.

This PR ensures that variables passed via query string are properly decoded and passed to the engine.

Scope

  • Decode query parameter variables as JSON for GET and POST requests
  • Ensure that every supported querying method supports variables
  • Add tests to cover variable handling
  • Fix code checks that are currently failing [can be descoped and moved to a different PR if required]

Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

src/tartiflette_asgi/_endpoints.py Outdated Show resolved Hide resolved
src/tartiflette_asgi/_endpoints.py Outdated Show resolved Hide resolved
@florimondmanca
Copy link
Contributor

florimondmanca commented May 11, 2022

@viernullvier Would you like to help with releasing this change once we merge this? It looks like this would be in a minor bump, so 0.12.0. We've got a guide on releasing in the contributing guide, here: https://github.com/tartiflette/tartiflette-asgi/blob/master/CONTRIBUTING.md#notes-to-maintainers

If so, let me know and I'll add you as a collaborator to the repo.

(This would come with absolutely no expectation of any future involvement required. But I'm a bit off with this project now (not using it myself), so deferring things to people actually using it whenever I can!)

@viernullvier
Copy link
Contributor Author

@florimondmanca Sure, happy to help out with that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants