Separate WikiNode.args into WikiNode.sarg and WikiNode.largs #87
Conversation
WikiNode previously had one attribute that held two kinds of argument data: either a single string, for things like HTML tag names, List "##*"-style level strings etc., or a list of lists containing more complicated data, like Template arguments and stuff. It's really hard to keep track of, and a really annoying thing to write well-typed code for. Because by necessity you'd need to have it be a [str | List[List[...]]], you have to constantly create phantom asserts either with `# type: ignore` or `if TYPE_CHECKING: assert...` to make type-checkers happy. `sarg` and `largs` are both preliminary names: string argument and list arguments, specifically, but if someone can come up with something better, these two should be unique enough to be easily replaceable.
|
IMO the problem is the |
|
It does feel like we could use a lot more classes than we do now, especially when using different WikiNode subclasses is almost free, because WikiNodes are already... classed objects, you know what I mean. However, this is the smallest change I could think of that shouldn't break anything, and it will also make it easier to do later changes ( |
WikiNode previously had one attribute that held two kinds of argument data: either a single string, for things like HTML tag names, List "##*"-style level strings etc., or a list of lists containing more complicated data, like Template arguments and stuff.
It's really hard to keep track of, and a really annoying thing to write well-typed code for. Because by necessity you'd need to have it be a [str | List[List[...]]], you have to constantly create phantom asserts either with
# type: ignoreorif TYPE_CHECKING: assert...to make type-checkers happy.sargandlargsare both preliminary names: string argument and list arguments, specifically, but if someone can come up with something better, these two should be unique enough to be easily replaceable.