Support multiprocessing on macOS and Windows #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This callback function was added for select pages in some namspaces, this should be done with the `namespace_ids` arguemnt to query the sqlite database. Also fix the subprocess still running resouce warning.
The code doesn't reply on the Linux fork method to copy variables now. multiprocessing code are moved to wiktextract, unpicklable objects like sqlite connection and lupa runtime are handled at there.
This file is mostly test the `process_dump()`, move it to `tests/test_dumppaser.py`. Extract each page is still tested in wiktextract.
`get_page()` is kind slow(1s per call), cache the requests improve the performance significantly. This reduces the process time of Chinese Wiktionary from 40 minutes to 10 minutes.
|
4b3d963 makes the code 4 times faster. But I don't know why this simple SQL is slow. |
Using `pkg_resources` is not recommanded: https://setuptools.pypa.io/en/latest/pkg_resources.html
The English Wiktionary has 40327 template and 54524 module pages(exclude redirects). I think the cache is mostly useful for caching shared templat and module pages used in pages processes in a worker process. So the cache size relates to page numbers, CPU core numbers and shared templates. If 1000 is not enough, we can increase it to 10000.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm also planning to replace the deprecated
pkg_resourcesmodule, I'll do that next week.