adds LastModifed to object as last_modifed

[samueleaton]

exposes the LastModifed time string to the user

example:

client.list_objects(bucket: BUCKET, max_keys: 10).each do |response|
  keys = response.contents.sort_by do |o|
    Time.parse!(o.last_modified, "%FT%T")
  end.map(&.key)

  p keys
end

[samueleaton]

S3 and DigitalOcean spaces both seem to use ISO string where the date and time are separated by a T.

I could parse the times so @last_modifed is a Time instead of a String.
I'm just not aware of any edge cases, like if times are ever stored without milliseconds, or if they are always in UTC time.

[taylorfinnell]

Thanks! I think parsing it as a Time would be solid. Doing that in other places like https://github.com/taylorfinnell/awscr-s3/blob/master/src/awscr-s3/responses/list_all_my_buckets.cr#L23 albeit it needs to be fixed there :)

[taylorfinnell]

It's slightly confusing both of these have the same last_modifed, despite being different in the xml response. Took me a while to figure out why the tests passed until I remembered how the Object equality was implemented. I wonder if last_modified should be added to the def_equals

[samueleaton]

Oh awesome i didn't know def_equals was a thing. I'll replace that helper i added with this

[taylorfinnell]

Needs a space, above it (or just run crystal tool format) and test description is repeated :).

[samueleaton]

I tried to use the existing Time Format string you showed me above but the time returned by DigitalOcean uses a decimal precision (e.g. 2019-03-06T01:52:47.037Z) so it breaks when it sees the period. Should we do it without decimal precision or a timezone and just parse it as UTC?

Example:

# "%Y-%M-%dT%H:%M:%S" is the same as "%FT%T"
last_modified = Time.parse(object.string("LastModified"), "%FT%T", Time::Location::UTC)

(When you don't specify a timezone in the time format string it required a location)

[taylorfinnell]

It looks like if a timestamp format is not specified the Ruby gem parses UTC and iso 8601. So I guess let's do that

https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-core/lib/aws-sdk-core/xml/builder.rb#L108